Skip to content

[ci] Update deps version for env setup#2690

Merged
VietND96 merged 1 commit intotrunkfrom
update-env-setup
Mar 3, 2025
Merged

[ci] Update deps version for env setup#2690
VietND96 merged 1 commit intotrunkfrom
update-env-setup

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Mar 3, 2025 •
edited by qodo-code-review bot
Loading

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Configuration changes

Description

  • Updated multiple dependency versions for environment setup.

  • Replaced deprecated Docker commands with modern alternatives.

  • Updated Kubernetes versions in CI workflows for compatibility.

  • Improved CI scripts for better maintainability and consistency.

Changes walkthrough 📝

Relevant files
Enhancement
chart_setup_env.sh
Update dependencies and Docker commands in setup script   

tests/charts/make/chart_setup_env.sh

  • Updated Docker Compose version to v2.33.1.
  • Replaced deprecated Docker commands with tonistiigi/binfmt.
  • Updated Go version to 1.24.0.
  • Updated CRI-CTL, CRI-Dockerd, and CNI-Plugins versions.
  • Updated Helm chart-testing version to 3.12.0.
    		• +8/-9     
    Configuration changes
    helm-chart-test.yml
    Update Kubernetes and Helm versions in CI workflow             

    .github/workflows/helm-chart-test.yml

  • Updated Kubernetes versions in matrix configurations.
  • Adjusted Helm versions for compatibility.
    		• +4/-4     
    k8s-scaling-test.yml
    Update Kubernetes versions in scaling test workflow           

    .github/workflows/k8s-scaling-test.yml

  • Updated Kubernetes versions in scaling test configurations.
  • Ensured compatibility with updated dependencies.
    		• +6/-6     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @VietND96
    [ci] Update deps version for env setup
    b25fa55 
    Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility

    The Go version 1.24.0 seems unusually high as Go 1.22 is the latest stable release. This could cause compatibility issues.

     
    GO_VERSION="1.24.0"
    Version Mismatch

    Some Kubernetes versions like v1.29.14 and v1.30.10 appear to be non-standard version numbers and may not exist in official releases.

     
    - k8s-version: 'v1.29.14'
  test-strategy: job_https
  cluster: 'minikube'
  helm-version: 'v3.14.3'
  docker-version: '26.1.4'
  python-version: '3.11'
  test-upgrade: true
  service-mesh: false
  os: ubuntu-24.04
- k8s-version: 'v1.30.10'

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 3, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Remove redundant conditional code block

    The same Docker command is duplicated in both if/else branches. Consolidate the
    identical commands outside the conditional block to improve maintainability and
    reduce redundancy.

    tests/charts/make/chart_setup_env.sh [45-49]

    -if [ "$(dpkg --print-architecture)" = "amd64" ]; then
-    docker run --privileged --rm tonistiigi/binfmt --install all
-else
-    docker run --privileged --rm tonistiigi/binfmt --install all
-fi
+docker run --privileged --rm tonistiigi/binfmt --install all
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion correctly identifies and eliminates redundant code by removing an unnecessary if/else block where both branches execute the exact same command, improving code maintainability and readability.

    		Medium
    • More

    @VietND96 VietND96 merged commit d607e5c into trunk Mar 3, 2025
    22 of 26 checks passed
    @VietND96 VietND96 deleted the update-env-setup branch March 3, 2025 11:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @VietND96